netdev - Re: [PATCH 1/1] vhost: change the signature of __vhost_get_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12b14053-b3ef-0616-6057-0406e7fd01bf@redhat.com>
Date:   Wed, 15 Aug 2018 11:22:50 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Dongli Zhang <dongli.zhang@...cle.com>, kvm@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, mst@...hat.com,
        virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH 1/1] vhost: change the signature of
 __vhost_get_user_slow()



On 2018年08月15日 09:46, Dongli Zhang wrote:
> Remove 'type' from the signature of __vhost_get_user_slow() as it is not
> used.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>
> ---
>   drivers/vhost/vhost.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index ed31145..f78d3bc 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -807,8 +807,7 @@ static int vhost_copy_from_user(struct vhost_virtqueue *vq, void *to,
>   }
>   
>   static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq,
> -					  void __user *addr, unsigned int size,
> -					  int type)
> +					  void __user *addr, unsigned int size)
>   {
>   	int ret;
>   
> @@ -846,7 +845,7 @@ static inline void __user *__vhost_get_user(struct vhost_virtqueue *vq,
>   	if (uaddr)
>   		return uaddr;
>   
> -	return __vhost_get_user_slow(vq, addr, size, type);
> +	return __vhost_get_user_slow(vq, addr, size);
>   }
>   
>   #define vhost_put_user(vq, x, ptr)		\

Please keep this as is.

It will be used by incoming packed virtqueue.

Thanks