netdev - Re: [Patch net-next] ila: make lockdep happy again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180816.121502.1913832368087636174.davem@davemloft.net>
Date:   Thu, 16 Aug 2018 12:15:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, tom@...ntonium.net
Subject: Re: [Patch net-next] ila: make lockdep happy again

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue, 14 Aug 2018 15:21:31 -0700

> Previously, alloc_ila_locks() and bucket_table_alloc() call
> spin_lock_init() separately, therefore they have two different
> lock names and lock class keys. However, after commit b893281715ab
> ("ila: Call library function alloc_bucket_locks") they both call
> helper alloc_bucket_spinlocks() which now only has one lock
> name and lock class key. This causes a few bogus lockdep warnings
> as reported by syzbot.
> 
> Fix this by making alloc_bucket_locks() a macro and pass declaration
> name as lock name and a static lock class key inside the macro.
> 
> Fixes: b893281715ab ("ila: Call library function alloc_bucket_locks")
> Reported-by: <syzbot+b66a5a554991a8ed027c@...kaller.appspotmail.com>
> Cc: Tom Herbert <tom@...ntonium.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thank you.