netdev - Re: [bpf-next RFC 1/3] flow_dissector: implements flow dissector BPF hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-+7Q1fo7mXLeHziQtpgjFFqv9omcHqgW3EKLVZ0ss-QcQ@mail.gmail.com>
Date:   Thu, 16 Aug 2018 18:37:02 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     ecree@...arflare.com
Cc:     Petar Penkov <peterpenkov96@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        simon.horman@...ronome.com, Petar Penkov <ppenkov@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [bpf-next RFC 1/3] flow_dissector: implements flow dissector BPF hook

On Thu, Aug 16, 2018 at 2:51 PM Edward Cree <ecree@...arflare.com> wrote:
>
> On 16/08/18 17:44, Petar Penkov wrote:
> > From: Petar Penkov <ppenkov@...gle.com>
> >
> > Adds a hook for programs of type BPF_PROG_TYPE_FLOW_DISSECTOR and
> > attach type BPF_FLOW_DISSECTOR that is executed in the flow dissector
> > path. The BPF program is kept as a global variable so it is
> > accessible to all flow dissectors.
> >
> > Signed-off-by: Petar Penkov <ppenkov@...gle.com>
> > Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> > ---
>
> This looks really great.
>
> > +int skb_flow_dissector_bpf_prog_detach(const union bpf_attr *attr)
> > +{
> > +     struct bpf_prog *attached;
> > +
> > +     mutex_lock(&flow_dissector_mutex);
> > +     attached = rcu_dereference_protected(flow_dissector_prog,
> > +                                          lockdep_is_held(&flow_dissector_mutex));
> > +     if (!flow_dissector_prog) {
> > +             mutex_unlock(&flow_dissector_mutex);
> > +             return -EINVAL;
> Wouldn't -ENOENT be more usual here (as the counterpart to -EEXIST in
>  the skb_flow_dissector_bpf_prog_attach() version just above)?

Absolutely. That better matches bpf_detach behavior, too.