netdev - RE: [PATCH] net: stmmac: Add SMC support for EMAC System Manager register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D53702B8F0ACD34B9B1D7D82EE03C04507691FD8@PGSMSX101.gar.corp.intel.com>
Date:   Thu, 16 Aug 2018 03:39:36 +0000
From:   "Ooi, Joyce" <joyce.ooi@...el.com>
To:     David Miller <davem@...emloft.net>
CC:     "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Ong, Hean Loong" <hean.loong.ong@...el.com>,
        "Vandervennet, Yves" <yves.vandervennet@...el.com>
Subject: RE: [PATCH] net: stmmac: Add SMC support for EMAC System Manager
 register

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Tuesday, August 14, 2018 12:48 AM
> To: Ooi, Joyce <joyce.ooi@...el.com>
> Cc: peppe.cavallaro@...com; alexandre.torgue@...com;
> joabreu@...opsys.com; netdev@...r.kernel.org; linux-kernel@...r.kernel.org;
> Ong, Hean Loong <hean.loong.ong@...el.com>; Vandervennet, Yves
> <yves.vandervennet@...el.com>
> Subject: Re: [PATCH] net: stmmac: Add SMC support for EMAC System Manager
> register
> 
> From: "Ooi, Joyce" <joyce.ooi@...el.com>
> Date: Sun, 12 Aug 2018 23:41:34 -0700
> 
> > As there is restriction to access to EMAC System Manager registers in
> > the kernel for Intel Stratix10, the use of SMC calls are required and
> > added in dwmac-socfpga driver.
> >
> > Signed-off-by: Ooi, Joyce <joyce.ooi@...el.com>
> > ---
> > This patch is dependent on https://lkml.org/lkml/2018/7/26/624
> 
> I guess I cannot apply this to my networking tree then.
> 
> I would suggest that you make a helper in a header file which dos the special
> SMC EMAC accesses, or alternatively the regular regmap access, based upon the
> CPP ifdef.
Could you please explain what you mean by 'a helper in a header file'?

Thanks.
> 
> That way you won't have to put all of those CPP tests in the foo.c code.
> 
> Thanks.