netdev - Re: [bpf PATCH] samples/bpf: all XDP samples should unload xdp/bpf prog on SIGTERM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW7Fse3G4RdHeJHo1MyTKS7u+pmsAY3ux_mL9PjnsqDndQ@mail.gmail.com>
Date:   Wed, 15 Aug 2018 17:13:15 -0700
From:   Song Liu <liu.song.a23@...il.com>
To:     Y Song <ys114321@...il.com>
Cc:     Jesper Dangaard Brouer <brouer@...hat.com>,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        netdev <netdev@...r.kernel.org>, jhsiao@...hat.com
Subject: Re: [bpf PATCH] samples/bpf: all XDP samples should unload xdp/bpf
 prog on SIGTERM

On Wed, Aug 15, 2018 at 8:47 AM, Y Song <ys114321@...il.com> wrote:
> On Wed, Aug 15, 2018 at 7:57 AM, Jesper Dangaard Brouer
> <brouer@...hat.com> wrote:
>> It is common XDP practice to unload/deattach the XDP bpf program,
>> when the XDP sample program is Ctrl-C interrupted (SIGINT) or
>> killed (SIGTERM).
>>
>> The samples/bpf programs xdp_redirect_cpu and xdp_rxq_info,
>> forgot to trap signal SIGTERM (which is the default signal used
>> by the kill command).
>>
>> This was discovered by Red Hat QA, which automated scripts depend
>> on killing the XDP sample program after a timeout period.
>>
>> Fixes: fad3917e361b ("samples/bpf: add cpumap sample program xdp_redirect_cpu")
>> Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info")
>> Reported-by: Jean-Tsung Hsiao <jhsiao@...hat.com>
>> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
>
> Acked-by: Yonghong Song <yhs@...com>

Reviewed-by: Song Liu <songliubraving@...com>

>
>> ---
>>  samples/bpf/xdp_redirect_cpu_user.c |    3 ++-
>>  samples/bpf/xdp_rxq_info_user.c     |    3 ++-
>>  2 files changed, 4 insertions(+), 2 deletions(-)