netdev - Re: [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src' for 'encap ip' / 'encap ip6'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180817203729.10c7a830@pixies>
Date:   Fri, 17 Aug 2018 20:37:29 +0300
From:   Shmulik Ladkani <shmulik@...anetworks.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        Shmulik Ladkani <shmulik.ladkani@...il.com>
Cc:     dsahern@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] iproute_lwtunnel: allow specifying 'src'
 for 'encap ip' / 'encap ip6'

Hi,

On Fri, 17 Aug 2018 08:00:22 -0700
Stephen Hemminger <stephen@...workplumber.org> wrote:

> If you accept an attribute on input you need to parse it and display it the
> same way in the show command.

Note print_encap_ip and print_encap_ip6 already handle LWTUNNEL_IP_SRC
and LWTUNNEL_IP6_SRC (since long ago, 1e5293056 and d95cdcf52).

The only missing part is treatment in parse_encap_ip and
parse_encap_ip6, as suggested by this patch.

Best,
Shmulik