lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 18 Aug 2018 13:58:19 -0700 (PDT) From: David Miller <davem@...emloft.net> To: guru2018@...il.com Cc: netdev@...r.kernel.org, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org Subject: Re: [PATCH]ipv6: multicast: In mld_send_cr function moving read lock to second for loop From: Guruswamy Basavaiah <guru2018@...il.com> Date: Fri, 17 Aug 2018 18:01:41 +0530 > @@ -1860,7 +1860,6 @@ static void mld_send_cr(struct inet6_dev *idev) > struct sk_buff *skb = NULL; > int type, dtype; > > - read_lock_bh(&idev->lock); > spin_lock(&idev->mc_lock); > > /* deleted MCA's */ This will lead to deadlocks, idev->mc_lock must be taken with _bh(). I have zero confidence in this change, did you do any stress testing with lockdep enabled? It would have caught this quickly.
Powered by blists - more mailing lists