lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Aug 2018 11:08:23 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jianjian.wang1@...il.com Cc: jasowang@...hat.com, mst@...hat.com, willemb@...gle.com, viro@...iv.linux.org.uk, wexu@...hat.com, netdev@...r.kernel.org Subject: Re: [PATCH 1/1] tap: RCU usage and comment fixes From: Wang Jian <jianjian.wang1@...il.com> Date: Fri, 17 Aug 2018 08:22:53 +0000 > The tap_queue and the 'tap_dev' are loosely coupled, not 'macvlan_dev'. There is another reference to macvlan_dev in that comment, which is therefore also similarly inaccurate. You should add an appropriate Fixes: line for where this inaccuracy was introduced, which is: Fixes: 6fe3faf86757 ("tap: Abstract type of virtual interface from tap implementation") > Taking rcu_read_lock a little later seems can slightly reduce rcu read critical section. This is a separate change from fixing up a comment.
Powered by blists - more mailing lists