netdev - Re: [PATCH bpf] xsk: fix return value of xdp_umem_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Aug 2018 10:31:37 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     bhole_prashant_q7@....ntt.co.jp
Cc:     ast@...nel.org, Daniel Borkmann <daniel@...earbox.net>,
        Björn Töpel <bjorn.topel@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf] xsk: fix return value of xdp_umem_assign_dev()

Den mån 20 aug. 2018 kl 02:58 skrev Prashant Bhole
<bhole_prashant_q7@....ntt.co.jp>:
>
> s/ENOTSUPP/EOPNOTSUPP/ in function umem_assign_dev().
> This function's return value is directly returned by xsk_bind().
> EOPNOTSUPP is bind()'s possible return value.
>
> Fixes: f734607e819b ("xsk: refactor xdp_umem_assign_dev()")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
> ---
>  net/xdp/xdp_umem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c
> index 911ca6d3cb5a..bfe2dbea480b 100644
> --- a/net/xdp/xdp_umem.c
> +++ b/net/xdp/xdp_umem.c
> @@ -74,14 +74,14 @@ int xdp_umem_assign_dev(struct xdp_umem *umem, struct net_device *dev,
>                 return 0;
>
>         if (!dev->netdev_ops->ndo_bpf || !dev->netdev_ops->ndo_xsk_async_xmit)
> -               return force_zc ? -ENOTSUPP : 0; /* fail or fallback */
> +               return force_zc ? -EOPNOTSUPP : 0; /* fail or fallback */
>
>         bpf.command = XDP_QUERY_XSK_UMEM;
>
>         rtnl_lock();
>         err = xdp_umem_query(dev, queue_id);
>         if (err) {
> -               err = err < 0 ? -ENOTSUPP : -EBUSY;
> +               err = err < 0 ? -EOPNOTSUPP : -EBUSY;
>                 goto err_rtnl_unlock;
>         }
>
> --
> 2.17.1
>
>

Acked-by: Björn Töpel <bjorn.topel@...el.com>