netdev - Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <addb4648-7036-ebe4-50d9-2d2dd9173a94@pengutronix.de>
Date:   Mon, 20 Aug 2018 14:17:33 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        netdev@...r.kernel.org, mdf@...nel.org, stable@...r.kernel.org,
        kernel@...gutronix.de, Brad Mouring <brad.mouring@...com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] net: macb: Fix regression breaking non-MDIO fixed-link
 PHYs

On 08/16/2018 04:24 PM, Andrew Lunn wrote:
> 1) A regression. We should find a fix for that. Maybe we should
>    special case a child node called 'fixed-link' in
>    of_mdiobus_register(). I would suggest adding a single warning if
>    such node is found.

I just sent out a v2, which warns if fixed-link is encountered
in of_mdiobus_register(). The actual fixed-link handling remains in the
macb driver, because I think it's would be out of scope for a regression
fix to change where fixed-links are handled for all using drivers...

> 2) Missing functionality. Add support for an mdio container node. 
> 
>         node = of_get_child_by_name(np, "mdio");
>         if (node)
> 		err = of_mdiobus_register(bp->mii_bus, node);
>         else 
> 		err = of_mdiobus_register(bp->mii_bus, np);

Done.
 
> 3) Modify the existing dts files to make use of this container.
>    Because of backwards compatibility, we cannot force the use of it,
>    but we can encourage it.

Done as well.

Cheers
Ahmad