netdev - Re: [RFC v3 net-next 4/5] rds: invoke socket sg filter attached to rds socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abcea3e5-8666-1ee5-9414-0ccdbc35cc5b@oracle.com>
Date:   Mon, 20 Aug 2018 09:58:15 -0700
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Tushar Dave <tushar.n.dave@...cle.com>, daniel@...earbox.net,
        davem@...emloft.net, sowmini.varadhan@...cle.com,
        jakub.kicinski@...ronome.com, quentin.monnet@...ronome.com,
        jiong.wang@...ronome.com, sandipan@...ux.vnet.ibm.com,
        kafai@...com, rdna@...com
Cc:     john.fastabend@...il.com, ast@...nel.org, yhs@...com,
        netdev@...r.kernel.org
Subject: Re: [RFC v3 net-next 4/5] rds: invoke socket sg filter attached to
 rds socket

On 8/17/2018 4:08 PM, Tushar Dave wrote:
> RDS module sits on top of TCP (rds_tcp) and IB (rds_rdma), so messages
> arrive in form of skb (over TCP) and scatterlist (over IB/RDMA).
> However, because socket filter only deal with skb (e.g. struct skb as
> bpf context) we can only use socket filter for rds_tcp and not for
> rds_rdma.
> 
> Considering one filtering solution for RDS, it seems that the common
> denominator between sk_buff and scatterlist is scatterlist. Therefore,
> this patch converts skb to sgvec and invoke sg_filter_run for
> rds_tcp and simply invoke sg_filter_run for IB/rds_rdma.
> 
> Signed-off-by: Tushar Dave <tushar.n.dave@...cle.com>
> Reviewed-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> ---

Looks good Tushar !!

Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>