lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Aug 2018 17:30:01 -0700 (PDT) From: David Miller <davem@...emloft.net> To: doronrk@...com Cc: davejwatson@...com, vakul.garg@....com, borisp@...lanox.com, aviadye@...lanox.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next,v4] net/tls: Calculate nsg for zerocopy path without skb_cow_data. From: Doron Roberts-Kedes <doronrk@...com> Date: Mon, 20 Aug 2018 17:27:23 -0700 > Given that frag_lists are not unlikely in this case, I believe the only > remaining feedback on the original patch was the recursive > implementation. If you'd like, I can re-submit with an iterative > implementation, but I noticed that goes against the existing recursive > pattern in functions like skb_release_data -> kfree_skb_list -> kfree_skb > -> __kfree_skb -> skb_release_all -> skb_release_data, as well as > skb_to_sgvec. Let me know whether an iterative implementation is > preferred here, or whether I can simply rebase and resubmit a patch > similar to the original (modulo some variable renaming improvements). Ok, I guess staying with the recursive implementation is fine. It's a real shame that frag lists are so common in this code path, especially nested ones :-/ In the long term, perhaps we can do something about that. In the short term, I guess this means your original change is OK. Please resubmit when the net-next tree opens back up, thanks.
Powered by blists - more mailing lists