netdev - Re: [PATCH] tipc: fix issue that tipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E0E1BFBA-FB75-4ACC-AAE1-14647A0BEA7F@windriver.com>
Date:   Tue, 21 Aug 2018 09:57:25 +0000
From:   "Xue, Ying" <Ying.Xue@...driver.com>
To:     Jon Maloy <jon.maloy@...csson.com>
CC:     David Miller <davem@...emloft.net>,
        "Bai, Haiqing" <Haiqing.Bai@...driver.com>,
        "Gao, Zhenbo" <Zhenbo.Gao@...driver.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tipc: fix issue that tipc_dest neglects of big-endian

Sorry, I am on vacation too. I agree with Jon. Please temporarily hold this patch. Once I am back, I will review it as soon as possible.

Sent from my iPhone

> On Aug 21, 2018, at 9:52 PM, Jon Maloy <jon.maloy@...csson.com> wrote:
> 
> Hi David, 
> Please hold this one for now. 
> 
> ///jon
> 
>> -----Original Message-----
>> From: David Miller <davem@...emloft.net>
>> Sent: Monday, 20 August, 2018 22:21
>> To: Haiqing.Bai@...driver.com
>> Cc: Jon Maloy <jon.maloy@...csson.com>; ying.xue@...driver.com; zhenbo.gao@...driver.com; netdev@...r.kernel.org; linux-
>> kernel@...r.kernel.org
>> Subject: Re: [PATCH] tipc: fix issue that tipc_dest neglects of big-endian
>> 
>> From: Haiqing Bai <Haiqing.Bai@...driver.com>
>> Date: Mon, 20 Aug 2018 18:26:01 +0800
>> 
>>> The tipc multicast demo in tipcutils fails to work on big-endian hardware.
>>> The tipc multicast server can not receive the packets sent by the multicast
>>> client for that the dest port is always zero after tipc_dest_pop, then it
>>> is found that the struct tipc_dest fails to take big/little endian into
>>> account.
>>> 
>>> Signed-off-by: Haiqing Bai <Haiqing.Bai@...driver.com>
>>> Signed-off-by: Zhenbo Gao <zhenbo.gao@...driver.com>
>> 
>> Jon and Ying, please review.
>> 
>> thank you.