netdev - Re: [PATCH] testsuite: Handle large number of kernel options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1534935771.5764.109.camel@debian.org>
Date:   Wed, 22 Aug 2018 12:02:51 +0100
From:   Luca Boccassi <bluca@...ian.org>
To:     Stefan Bader <stefan.bader@...onical.com>,
        net-devel <netdev@...r.kernel.org>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Christian Ehrhardt <christian.ehrhardt@...onical.com>
Subject: Re: [PATCH] testsuite: Handle large number of kernel options

On Wed, 2018-08-22 at 10:31 +0200, Stefan Bader wrote:
> Once there are more than a certain number of kernel config options
> set (this happened for us with kernel 4.17), the method of passing
> those as command line arguments exceeds the maximum number of
> arguments the shell supports. This causes the whole testsuite to
> fail.
> Instead, create a temporary file and modify its contents so that
> the config option variables are exported. Then this file can be
> sourced in before running the tests.
> 
> Signed-off-by: Stefan Bader <stefan.bader@...onical.com>
> ---
>  testsuite/Makefile | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/testsuite/Makefile b/testsuite/Makefile
> index 8fcbc55..f9f3b19 100644

Acked-by: Luca Boccassi <bluca@...ian.org>

Looks good to me, thanks.

-- 
Kind regards,
Luca Boccassi
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)