netdev - Re: [PATCH] RDMA/smc: Replace ib_query_gid with rdma_get_gid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Aug 2018 16:19:37 +0200
From:   Hans Wippel <hwippel@...ux.ibm.com>
To:     Jason Gunthorpe <jgg@...lanox.com>,
        Ursula Braun <ubraun@...ux.ibm.com>
Cc:     linux-rdma@...r.kernel.org, Parav Pandit <parav@...lanox.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/smc: Replace ib_query_gid with rdma_get_gid_attr

On 08/18/2018 04:17 AM, Jason Gunthorpe wrote:
> All RDMA ULPs should be using rdma_get_gid_attr instead of
> ib_query_gid. Convert SMC to use the new API.
> 
> In the process correct some confusion with gid_type - if attr->ndev is
> !NULL then gid_type can never be IB_GID_TYPE_IB by
> definition. IB_GID_TYPE_ROCE shares the same enum value and is probably
> what was intended here.
> 
> Reviewed-by: Parav Pandit <parav@...lanox.com>
> Signed-off-by: Jason Gunthorpe <jgg@...lanox.com>

I ran a few SMC tests and the changes look good. So, no objections from 
our side and thank you for the patch.

Hans