lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Aug 2018 08:31:42 +0000 From: Fabrizio Castro <fabrizio.castro@...renesas.com> To: Simon Horman <horms@...ge.net.au>, Chris Paterson <Chris.Paterson2@...esas.com> CC: Wolfgang Grandegger <wg@...ndegger.com>, Marc Kleine-Budde <mkl@...gutronix.de>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, "David S. Miller" <davem@...emloft.net>, "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Biju Das <biju.das@...renesas.com>, "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support Hello Simon, Thank you for the feedback! > > > > In theory CAN could be broken if renesas,can-clock-select is set to 0x1 > > (clkp2) in the DT, as this value will be written to the CAN Clock Select > > Register. However if the documentation is followed there will be no > > problems. > > > > We should probably update the driver to fix this though, which will be a > > change specific to all RZ/G2 devices, so perhaps we should also be adding > > a "renesas,rzg-gen2-can" family compatible string as well? (to driver and > > documentation) > > Yes, I think that sounds reasonable. > > But in that case we should pre-emptively not use renesas,rcar-gen3-can for > RZ/G2. What do you think about the following: https://patchwork.kernel.org/patch/10573795/ https://patchwork.kernel.org/patch/10573791/ https://patchwork.kernel.org/patch/10573805/ Thanks, Fab Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Powered by blists - more mailing lists