netdev - Re: [PATCH] iwlwifi: d3: use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6818e31-d2da-82b4-b862-1ffb322f9365@embeddedor.com>
Date:   Fri, 24 Aug 2018 06:58:05 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Joe Perches <joe@...ches.com>, Kees Cook <keescook@...omium.org>
Cc:     Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: d3: use struct_size() in kzalloc()

Hi Joe,

On 8/23/18 11:33 PM, Joe Perches wrote:
> On Thu, 2018-08-23 at 20:03 -0700, Kees Cook wrote:
>> On Thu, Aug 23, 2018 at 6:15 PM, Gustavo A. R. Silva
>> <gustavo@...eddedor.com> wrote:
>>> One of the more common cases of allocation size calculations is finding
>>> the size of a structure that has a zero-sized array at the end, along
>>> with memory for some number of elements for that array. For example:
>>>
>>> struct foo {
>>>         int stuff;
>>>         void *entry[];
>>> };
> 
> Question for Gustavo.
> 
> Did you find any existing instances that are miscalculated?
> 

I found the following bug:

https://lore.kernel.org/patchwork/patch/977357/


> I believe there are some cases like:
> 
> 	size = sizeof(struct foo) + count * sizeof(something);
> 	ptr = kmalloc(size);
> 	memset(ptr + sizeof(struct foo), 0, size - sizeof(struct foo));
> 
> where something could go wrong and not be detected.
> 

It might be worth it to write a Coccinelle script for this.

--
Gustavo