netdev - RE: [net 07/13] ice: Use order_base_2 to calculate higher power of 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 Aug 2018 15:39:35 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "jogreene@...hat.com" <jogreene@...hat.com>,
        "Venkataramanan, Anirudh" <anirudh.venkataramanan@...el.com>
Subject: RE: [net 07/13] ice: Use order_base_2 to calculate higher power of 2



> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Sergei Shtylyov
> Sent: Friday, August 24, 2018 2:03 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; davem@...emloft.net
> Cc: Keller, Jacob E <jacob.e.keller@...el.com>; netdev@...r.kernel.org;
> nhorman@...hat.com; sassmann@...hat.com; jogreene@...hat.com;
> Venkataramanan, Anirudh <anirudh.venkataramanan@...el.com>
> Subject: Re: [net 07/13] ice: Use order_base_2 to calculate higher power of 2
> 
> Hello!
> 
> On 8/23/2018 10:14 PM, Jeff Kirsher wrote:
> 
> > From: Jacob Keller <jacob.e.keller@...el.com>
> >
> > Currently, we use a combination of ilog2 and is_power_of_2() to
> > calculate the next power of 2 for the qcount. This appears to be causing
> > a warning on some combinations of GCC and the Linux kernel:
> >
> > MODPOST 1 modules
> > WARNING: "____ilog2_NaN" [ice.ko] undefined!
> >
> > This appears to because because GCC realizes that qcount could be zero
> 
>     One "because" is enough. :-)

Woops! Thanks for catching it.

Regards,
Jake