netdev - Re: [PATCH v2] net: macb: do not disable MDIO bus at open/close time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180825.173521.164329277597524488.davem@davemloft.net>
Date:   Sat, 25 Aug 2018 17:35:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     anssi.hannula@...wise.fi
Cc:     netdev@...r.kernel.org, nicolas.ferre@...rochip.com,
        Claudiu.Beznea@...rochip.com, andrew@...n.ch
Subject: Re: [PATCH v2] net: macb: do not disable MDIO bus at open/close
 time

From: Anssi Hannula <anssi.hannula@...wise.fi>
Date: Thu, 23 Aug 2018 10:45:22 +0300

> macb_reset_hw() is called from macb_close() and indirectly from
> macb_open(). macb_reset_hw() zeroes the NCR register, including the MPE
> (Management Port Enable) bit.
> 
> This will prevent accessing any other PHYs for other Ethernet MACs on
> the MDIO bus, which remains registered at macb_reset_hw() time, until
> macb_init_hw() is called from macb_open() which sets the MPE bit again.
> 
> I.e. currently the MDIO bus has a short disruption at open time and is
> disabled at close time until the interface is opened again.
> 
> Fix that by only touching the RE and TE bits when enabling and disabling
> RX/TX.
> 
> v2: Make macb_init_hw() NCR write a single statement.
> 
> Fixes: 6c36a7074436 ("macb: Use generic PHY layer")
> Signed-off-by: Anssi Hannula <anssi.hannula@...wise.fi>

Applied and queued up for -stable.