netdev - Re: [PATCH net 1/1] qlge: Fix netdev features configuration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180825.173829.1893118882508364882.davem@davemloft.net>
Date:   Sat, 25 Aug 2018 17:38:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     manish.chopra@...ium.com
Cc:     netdev@...r.kernel.org, Dept-GELinuxNICDev@...ium.com,
        bpoirier@...e.com
Subject: Re: [PATCH net 1/1] qlge: Fix netdev features configuration.

From: Manish Chopra <manish.chopra@...ium.com>
Date: Thu, 23 Aug 2018 13:20:52 -0700

> qlge_fix_features() is not supposed to modify hardware or
> driver state, rather it is supposed to only fix requested
> fetures bits. Currently qlge_fix_features() also goes for
> interface down and up unnecessarily if there is not even
> any change in features set.
> 
> This patch changes/fixes following -
> 
> 1) Move reload of interface or device re-config from
>    qlge_fix_features() to qlge_set_features().
> 2) Reload of interface in qlge_set_features() only if
>    relevant feature bit (NETIF_F_HW_VLAN_CTAG_RX) is changed.
> 3) Get rid of qlge_fix_features() since driver is not really
>    required to fix any features bit.
> 
> Signed-off-by: Manish <manish.chopra@...ium.com>
> Reviewed-by: Benjamin Poirier <bpoirier@...e.com>

Applied and queued up for -stable.

Please provide a proper Fixes: tag next time.

Thanks.