netdev - RE: [PATCH] sh_eth: Add R7S9210 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TY1PR01MB1562269EC6BE932742A119938A0B0@TY1PR01MB1562.jpnprd01.prod.outlook.com>
Date:   Mon, 27 Aug 2018 17:30:17 +0000
From:   Chris Brandt <Chris.Brandt@...esas.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Simon Horman <horms+renesas@...ge.net.au>
Subject: RE: [PATCH] sh_eth: Add R7S9210 support

Hi Sergei,

On Friday, August 24, 2018 1, linux-renesas-soc-owner@...r.kernel.org wrote:
> On 08/22/2018 11:57 PM, Chris Brandt wrote:
> > +static const u16 sh_eth_offset_fast_rza2[SH_ETH_MAX_REGISTER_OFFSET] =
> {
> > +	SH_ETH_OFFSET_DEFAULTS,
> > +
   (snip)
> > +	[RFCR]		= 0x01f4,
> > +	[MAFCR]		= 0x01f8,
> > +};
> > +
> 
>    This array is absolutely the same as sh_eth_offset_fast_sh4[], except
> the latter
> is (more or less) sorted.

You're right. I'll just use sh_eth_offset_fast_sh4[].


> > +
> > +	switch (mdp->speed) {
> > +	case 10: /* 10BASE */
> > +		sh_eth_modify(ndev, ECMR, RTM, 0);
> > +		break;
> > +	case 100:/* 100BASE */
> > +		sh_eth_modify(ndev, ECMR, RTM, RTM);
> > +		break;
> > +	}
> > +}
> > +
> 
>   Seems the same as sh_eth_set_rate_rcar(), except for the bit name...

You're right.
I looked at the other sh_eth_set_rate_xxx() but didn't seem to find one 
that matched.
But, sh_eth_set_rate_rcar() does match. I'll use that one.


Thanks,
Chris