netdev - Re: [PATCH] iprule: Fix destination prefix output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Aug 2018 16:38:45 +0100
From:   Luca Boccassi <bluca@...ian.org>
To:     Stefan Bader <stefan.bader@...onical.com>, netdev@...r.kernel.org
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Christian Ehrhardt <christian.ehrhardt@...onical.com>
Subject: Re: [PATCH] iprule: Fix destination prefix output

On Tue, 2018-08-28 at 16:27 +0200, Stefan Bader wrote:
> When adding support for JSON output the new code for printing
> the destination prefix adds a stray blank character before
> the bitmask. This causes some user-space parsing to fail.
> 
> Current output:
>   ...: from x.x.x.x/l to y.y.y.y /l
> Previous output:
>   ...: from x.x.x.x/l to y.y.y.y/l
> 
> Fixes: 0dd4ccc5 "iprule: add json support"
> Signed-off-by: Stefan Bader <stefan.bader@...onical.com>
> ---
>  ip/iprule.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ip/iprule.c b/ip/iprule.c
> index 8b94214..744d6d8 100644
> --- a/ip/iprule.c
> +++ b/ip/iprule.c
> @@ -239,7 +239,7 @@ int print_rule(const struct sockaddr_nl *who,
> struct nlmsghdr *n, void *arg)
>  
>  		print_string(PRINT_FP, NULL, "to ", NULL);
>  		print_color_string(PRINT_ANY, ifa_family_color(frh-
> >family),
> -				   "dst", "%s ", dst);
> +				   "dst", "%s", dst);
>  		if (frh->dst_len != host_len)
>  			print_uint(PRINT_ANY, "dstlen", "/%u ", frh-
> >dst_len);
>  		else

Acked-by: Luca Boccassi <bluca@...ian.org>

-- 
Kind regards,
Luca Boccassi
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)