netdev - Re: [PATCH] mac80211: fix to follow standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Aug 2018 12:23:35 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Yuan-Chi Pang <fu3mo6goo@...il.com>, johannes@...solutions.net
Cc:     davem@...emloft.net, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mac80211: fix to follow standard

Hello!

On 8/28/2018 5:24 AM, Yuan-Chi Pang wrote:

> IEEE 802.11-2016 14.10.8.3 HWMP sequence numbering says:
> If it is a target mesh STA, it shall update its own HWMP SN to
> maximum (current HWMP SN, target HWMP SN in the PREQ element) + 1
> immediately before it generates a PREP element in response to a
> PREQ element.
> 
> Signed-off-by: Yuan-Chi Pang <fu3mo6goo@...il.com>
> ---
>   net/mac80211/mesh_hwmp.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> index 35ad398..6c21a26 100644
> --- a/net/mac80211/mesh_hwmp.c
> +++ b/net/mac80211/mesh_hwmp.c
> @@ -572,6 +572,11 @@ static void hwmp_preq_frame_process(struct ieee80211_sub_if_data *sdata,
>   		forward = false;
>   		reply = true;
>   		target_metric = 0;
> +
> +		if (SN_GT(target_sn, ifmsh->sn)) {
> +			ifmsh->sn = target_sn;
> +		}

    No need for {} enclosing a single statement.

[...]

MBR, Sergei