netdev - Re: [PATCH net-next 5/5] ppp: handle PPPIOCGIDLE for 64-bit time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0B0u7dRajmTKZwXnuxjAiARJJTQguB1RUsEASDbq7TkA@mail.gmail.com>
Date:   Thu, 30 Aug 2018 13:47:37 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     g.nault@...halink.fr
Cc:     Paul Mackerras <paulus@...ba.org>, linux-ppp@...r.kernel.org,
        Networking <netdev@...r.kernel.org>, mitch@...oth.com,
        mostrows@...thlink.net, jchapman@...alix.com, xeb@...l.ru,
        David Miller <davem@...emloft.net>,
        Al Viro <viro@...iv.linux.org.uk>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Karsten Keil <isdn@...ux-pingi.de>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH net-next 5/5] ppp: handle PPPIOCGIDLE for 64-bit time_t

On Thu, Aug 30, 2018 at 1:06 PM Guillaume Nault <g.nault@...halink.fr> wrote:
> On Wed, Aug 29, 2018 at 04:03:30PM +0200, Arnd Bergmann wrote:

> > @@ -743,10 +744,17 @@ static long ppp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> >               err = 0;
> >               break;
> >
> > -     case PPPIOCGIDLE:
> > -             idle.xmit_idle = (jiffies - ppp->last_xmit) / HZ;
> > -             idle.recv_idle = (jiffies - ppp->last_recv) / HZ;
> > -             if (copy_to_user(argp, &idle, sizeof(idle)))
> > +     case PPPIOCGIDLE32:
> > +                idle32.xmit_idle = (jiffies - ppp->last_xmit) / HZ;
> > +                idle32.recv_idle = (jiffies - ppp->last_recv) / HZ;
> > +                if (copy_to_user(argp, &idle32, sizeof(idle32)))
> >
> Missing 'break;'
>
> > +             err = 0;
> > +             break;
> > +
> > +     case PPPIOCGIDLE64:
> > +             idle64.xmit_idle = (jiffies - ppp->last_xmit) / HZ;
> > +             idle64.recv_idle = (jiffies - ppp->last_recv) / HZ;
> > +             if (copy_to_user(argp, &idle32, sizeof(idle32)))
> >
> I guess you meant 'idle64' instead of 'idle32'.

Good catch, fixing up both now.

Thanks for the review!

     Arnd