netdev - Re: [PATCH net] tcp: do not restart timewait timer on rst reception

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3281b8a6-d862-d634-d65c-92c889fc4b28@gmail.com>
Date:   Thu, 30 Aug 2018 08:07:26 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Cc:     edumazet@...gle.com
Subject: Re: [PATCH net] tcp: do not restart timewait timer on rst reception



On 08/30/2018 05:24 AM, Florian Westphal wrote:
> RFC 1337 says:
>  ''Ignore RST segments in TIME-WAIT state.
>    If the 2 minute MSL is enforced, this fix avoids all three hazards.''
> 
> So with net.ipv4.tcp_rfc1337=1, expected behaviour is to have TIME-WAIT sk
> expire rather than removing it instantly when a reset is received.
> 
> However, Linux will also re-start the TIME-WAIT timer.
> 
> This causes connect to fail when tying to re-use ports or very long
> delays (until syn retry interval exceeds MSL).
>


> Reported-by: Michal Tesar <mtesar@...hat.com>
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---

SGTM, thanks.

Signed-off-by: Eric Dumazet <edumazet@...gle.com>