netdev - Re: [PATCH V1] add huawei ibma driver modules The driver is used for communication between in-band management agent(iBMA) and out-of-band management controller(iBMC) via pcie bus in Huawei V3 server. The driver provides character device,VNIC and black box interface for application layer.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dc265e3c-3836-d954-5de3-d7b8701ce986@infradead.org>
Date:   Thu, 30 Aug 2018 10:15:04 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     xiongsujuan <xiongsujuan.xiongsujuan@...wei.com>,
        davem@...emloft.net, zhaochen6@...wei.com,
        aviad.krawczyk@...wei.com, romain.perier@...labora.com,
        bhelgaas@...gle.com, keescook@...omium.org,
        colin.king@...onical.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1] add huawei ibma driver modules The driver is used for
 communication between in-band management agent(iBMA) and out-of-band
 management controller(iBMC) via pcie bus in Huawei V3 server. The driver
 provides character device,VNIC and black box interface for application layer.

Hi,

Please fix the Subject: and patch description.

(more below)

On 08/29/2018 06:11 PM, xiongsujuan wrote:
> diff --git a/drivers/net/ethernet/huawei/Kconfig b/drivers/net/ethernet/huawei/Kconfig
> index c1a95ae..68748e9 100644
> --- a/drivers/net/ethernet/huawei/Kconfig
> +++ b/drivers/net/ethernet/huawei/Kconfig
> @@ -4,7 +4,7 @@
>  
>  config NET_VENDOR_HUAWEI
>  	bool "Huawei devices"
> -	default y
> +	default y 

Don't add a space after the 'y'.

>  	---help---
>  	  If you have a network (Ethernet) card belonging to this class, say Y.
>  	  Note that the answer to this question doesn't directly affect the
> @@ -16,4 +16,7 @@ if NET_VENDOR_HUAWEI
>  
>  source "drivers/net/ethernet/huawei/hinic/Kconfig"
>  
> +source "drivers/net/ethernet/huawei/ibma/Kconfig"
> +
> +
>  endif # NET_VENDOR_HUAWEI

> diff --git a/drivers/net/ethernet/huawei/ibma/Kconfig b/drivers/net/ethernet/huawei/ibma/Kconfig
> new file mode 100644
> index 0000000..810cc60
> --- /dev/null
> +++ b/drivers/net/ethernet/huawei/ibma/Kconfig
> @@ -0,0 +1,17 @@
> +#
> +# Huawei driver configuration
> +#
> +
> +config IBMANIC
> +	tristate "Huawei IBMA PCIE Network Interface Card"
> +	depends on (PCI_MSI && X86)
> +	---help---
> +	  This driver supports IBMANIC PCIE Ethernet cards.
> +	  To compile this driver as part of the kernel, choose Y here.
> +	  If unsure, choose N.
> +	  The default is compiled as module.
> +
> +
> +
> +
> +

Drop those trailing blank lines.

What makes the default be compiled as module?

thanks,
-- 
~Randy