lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20180829.194628.1640012269371401850.davem@davemloft.net> Date: Wed, 29 Aug 2018 19:46:28 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mkubecek@...e.cz Cc: netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com, linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next 0/2] ethtool: drop get_settings and set_settings ops From: Michal Kubecek <mkubecek@...e.cz> Date: Tue, 28 Aug 2018 19:56:48 +0200 (CEST) > As Andrew Lunn pointed out in recent discussion, there is only one in tree > driver left which still defines deprecated callbacks get_settings() and > set_settings() in ethtool_ops. First patch converts this driver to > get_link_ksettings() and set_link_ksettings(). Second patch then removes > the deprecated callbacks from struct ethtool_ops and ethtool code which > falls back to them. > > This doesn't break old versions of ethtool or any other userspace code > using ETHTOOL_{G,S}SET. We still implement both (old) ETHTOOL_{G,S}SET and > (new) ETHTOOL_{G,S}LINKSETTINGS ioctl commands but after this series both > will be implemented only using {g,s}et_link_ksettings(). The only affected > code would be out of tree NIC drivers which have not been converted yet. Nice, thanks for following up on this. Series applied.
Powered by blists - more mailing lists