lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <153560076419.129321.1550199570456759259@swboyd.mtv.corp.google.com> Date: Wed, 29 Aug 2018 20:46:04 -0700 From: Stephen Boyd <sboyd@...nel.org> To: "David S . Miller" <davem@...emloft.net>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Hans de Goede <hdegoede@...hat.com>, Heiner Kallweit <hkallweit1@...il.com>, Irina Tirdea <irina.tirdea@...el.com>, Michael Turquette <mturquette@...libre.com> Cc: Hans de Goede <hdegoede@...hat.com>, netdev@...r.kernel.org, Johannes Stezenbach <js@...21.net>, Carlo Caione <carlo@...lessm.com>, linux-clk@...r.kernel.org Subject: Re: [PATCH 3/4] clk: x86: Stop marking clocks as CLK_IS_CRITICAL Quoting Hans de Goede (2018-08-27 07:31:59) > Commit d31fd43c0f9a ("clk: x86: Do not gate clocks enabled by the > firmware"), which added the code to mark clocks as CLK_IS_CRITICAL, causes > all unclaimed PMC clocks on Cherry Trail devices to be on all the time, > resulting on the device not being able to reach S0i3 when suspended. > > The reason for this commit is that on some Bay Trail / Cherry Trail devices > the r8169 ethernet controller uses pmc_plt_clk_4. Now that the clk-pmc-atom > driver exports an "ether_clk" alias for pmc_plt_clk_4 and the r8169 driver > has been modified to get and enable this clock (if present) the marking of > the clocks as CLK_IS_CRITICAL is no longer necessary. > > This commit removes the CLK_IS_CRITICAL marking, fixing Cherry Trail > devices not being able to reach S0i3 greatly decreasing their battery > drain when suspended. > > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=193891#c102 > Cc: Johannes Stezenbach <js@...21.net> > Cc: Carlo Caione <carlo@...lessm.com> > Signed-off-by: Hans de Goede <hdegoede@...hat.com> > --- Acked-by: Stephen Boyd <sboyd@...nel.org>
Powered by blists - more mailing lists