netdev - Re: [PATCH v2] net: mvpp2: initialize port of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180829.220921.1139857086346702843.davem@davemloft.net>
Date:   Wed, 29 Aug 2018 22:09:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baruch@...s.co.il
Cc:     maxime.chevallier@...tlin.com, antoine.tenart@...tlin.com,
        jason@...edaemon.net, andrew@...n.ch, gregory.clement@...tlin.com,
        sebastian.hesselbarth@...il.com, linux@...linux.org.uk,
        ori.shemtov@...id-run.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: mvpp2: initialize port of_node pointer

From: Baruch Siach <baruch@...s.co.il>
Date: Wed, 29 Aug 2018 09:44:39 +0300

> Without a valid of_node in struct device we can't find the mvpp2 port
> device by its DT node. Specifically, this breaks
> of_find_net_device_by_node().
> 
> For example, the Armada 8040 based Clearfog GT-8K uses Marvell 88E6141
> switch connected to the &cp1_eth2 port:
> 
> &cp1_mdio {
> 	...
> 
> 	switch0: switch0@4 {
> 		compatible = "marvell,mv88e6085";
> 		...
> 
> 		ports {
> 			...
> 
> 			port@5 {
> 				reg = <5>;
> 				label = "cpu";
> 				ethernet = <&cp1_eth2>;
> 			};
> 		};
> 	};
> };
> 
> Without this patch, dsa_register_switch() returns -EPROBE_DEFER because
> of_find_net_device_by_node() can't find the device_node of the &cp1_eth2
> device.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Baruch Siach <baruch@...s.co.il>

Applied.