netdev - Re: [bpf PATCH] bpf: avoid kcm psock use and tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14e7eb8a-afcd-4b42-cece-ebd2f4641458@gmail.com>
Date:   Thu, 30 Aug 2018 17:24:03 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     ast@...nel.org, daniel@...earbox.net
Cc:     netdev@...r.kernel.org
Subject: Re: [bpf PATCH] bpf: avoid kcm psock use and tcp_bpf from colliding

On 08/30/2018 03:33 PM, John Fastabend wrote:
> Currently we check sk_user_data is non NULL to determine if the sk
> exists in a map. However, this is not sufficient to ensure the psock
> is not in use by another (non-ULP TCP) user, such as kcm. To avoid
> this when adding a sock to a map also verify it is of the correct ULP
> type.
> 
> Signed-off-by: John Fastabend <john.fastabend@...il.com>
> ---

I'll send a v2 of this we have one more spot we need to check
the psock type in the error path.

Thanks,
John