netdev - Re: linux-next: Tree for Aug 31 (nixge.c and phy)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180831175427.GC19733@lunn.ch>
Date:   Fri, 31 Aug 2018 19:54:27 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Moritz Fischer <moritz.fischer.private@...il.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>, sfr@...b.auug.org.au,
        linux-next@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev@...r.kernel.org
Subject: Re: linux-next: Tree for Aug 31 (nixge.c and phy)

> @@ -20,7 +20,6 @@ config NI_XGE_MANAGEMENT_ENET
>         tristate "National Instruments XGE management enet support"
>         depends on HAS_IOMEM && HAS_DMA
>         select PHYLIB
> -       select OF_MDIO
>         help
>           Simple LAN device for debug or management purposes. Can
>           support either 10G or 1G PHYs via SFP+ ports.

Hi Moritz

Since you are targeting both DT and non-DT systems, you cannot
unconditionally select OF_MDIO

What might work is

         select OF_MDIO if OF

	 Andrew