netdev - Re: [PATCH bpf-next] xsk: remove unnecessary assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ+HfNguVefGGKQY0As-ONGX=kxV_y4Jdt5j0WdBXh5ZYtD7=A@mail.gmail.com>
Date:   Fri, 31 Aug 2018 09:27:39 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     bhole_prashant_q7@....ntt.co.jp
Cc:     ast@...nel.org, Daniel Borkmann <daniel@...earbox.net>,
        Björn Töpel <bjorn.topel@...el.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next] xsk: remove unnecessary assignment

Den fre 31 aug. 2018 kl 03:02 skrev Prashant Bhole
<bhole_prashant_q7@....ntt.co.jp>:
>
> Since xdp_umem_query() was added one assignment of bpf.command was
> missed from cleanup. Removing the assignment statement.
>

Good catch!

Acked-by: Björn Töpel <bjorn.topel@...el.com>

> Fixes: 84c6b86875e01a0 ("xsk: don't allow umem replace at stack level")
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
> ---
>  net/xdp/xdp_umem.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c
> index bfe2dbea480b..d179732617dc 100644
> --- a/net/xdp/xdp_umem.c
> +++ b/net/xdp/xdp_umem.c
> @@ -76,8 +76,6 @@ int xdp_umem_assign_dev(struct xdp_umem *umem, struct net_device *dev,
>         if (!dev->netdev_ops->ndo_bpf || !dev->netdev_ops->ndo_xsk_async_xmit)
>                 return force_zc ? -EOPNOTSUPP : 0; /* fail or fallback */
>
> -       bpf.command = XDP_QUERY_XSK_UMEM;
> -
>         rtnl_lock();
>         err = xdp_umem_query(dev, queue_id);
>         if (err) {
> --
> 2.17.1
>
>