netdev - Re: [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180831104532.22093b6d@cakuba.netronome.com>
Date:   Fri, 31 Aug 2018 10:45:32 +0200
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Quentin Monnet <quentin.monnet@...ronome.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types

On Fri, 31 Aug 2018 15:32:42 +0900, Prashant Bhole wrote:
> When listed all maps, bpftool currently shows (null) for xskmap.
> Added xskmap type in map_type_name[] to show correct type.
> 
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Thank you!  I feel tempted to suggest considering the bpf tree, but
perhaps that's a stretch..

> diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c
> index df175bc33c5d..9c55077ca5dd 100644
> --- a/tools/bpf/bpftool/map.c
> +++ b/tools/bpf/bpftool/map.c
> @@ -68,6 +68,7 @@ static const char * const map_type_name[] = {
>  	[BPF_MAP_TYPE_DEVMAP]		= "devmap",
>  	[BPF_MAP_TYPE_SOCKMAP]		= "sockmap",
>  	[BPF_MAP_TYPE_CPUMAP]		= "cpumap",
> +	[BPF_MAP_TYPE_XSKMAP]           = "xskmap",
>  	[BPF_MAP_TYPE_SOCKHASH]		= "sockhash",
>  	[BPF_MAP_TYPE_CGROUP_STORAGE]	= "cgroup_storage",
>  };