netdev - Re: [PATCH] rsi: remove set but not used variable 'header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 31 Aug 2018 19:07:55 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Kalle Valo <kvalo@...eaurora.org>,
        Pavani Muthyala <pavani.muthyala@...pinesignals.com>,
        Kees Cook <keescook@...omium.org>,
        Colin Ian King <colin.king@...onical.com>,
        Amitkumar Karwar <amit.karwar@...pinesignals.com>,
        Prameela Rani Garnepudi <prameela.j04cs@...il.com>,
        Siva Rebbagondla <siva.rebbagondla@...pinesignals.com>,
        Sushant Kumar Mishra <sushant.mishra@...pinesignals.com>
CC:     <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] rsi: remove set but not used variable 'header_size'


On 2018/8/31 17:27, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_send_data_pkt':
> drivers/net/wireless/rsi/rsi_91x_hal.c:288:5: warning:
>  variable 'header_size' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/wireless/rsi/rsi_91x_hal.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
> index 01edf96..c4fb319 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_hal.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
> @@ -285,7 +285,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
>  	struct skb_info *tx_params;
>  	struct ieee80211_bss_conf *bss;
>  	int status = -EINVAL;
> -	u8 header_size;
>  
>  	if (!skb)
>  		return 0;
> @@ -298,7 +297,6 @@ int rsi_send_data_pkt(struct rsi_common *common, struct sk_buff *skb)
>  	vif = info->control.vif;
>  	bss = &vif->bss_conf;
>  	tx_params = (struct skb_info *)info->driver_data;

tx_params also can be removed.

Will send V2.

> -	header_size = tx_params->internal_hdr_size;
>  
>  	if (((vif->type == NL80211_IFTYPE_STATION) ||
>  	     (vif->type == NL80211_IFTYPE_P2P_CLIENT)) &&
> 
> 
> .
>