netdev - Re: [PATCH net-next] liquidio: cHECK-remove set but not used variable 'irh'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 Aug 2018 19:48:43 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Derek Chickles <derek.chickles@...iumnetworks.com>,
        Satanand Burla <satananda.burla@...iumnetworks.com>,
        Felix Manlunas <felix.manlunas@...iumnetworks.com>,
        Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>,
        "David S. Miller" <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net-next] liquidio: cHECK-remove set but not used variable
 'irh'

sorry, patch description is messy, will fix it in V2.

On 2018/8/31 19:53, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/cavium/liquidio/request_manager.c: In function 'lio_process_iq_request_list':
> drivers/net/ethernet/cavium/liquidio/request_manager.c:383:27: warning:
>  variable 'irh' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/ethernet/cavium/liquidio/request_manager.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> index bd0153e..c6f4cbd 100644
> --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
> +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> @@ -380,7 +380,6 @@ static inline void __copy_cmd_into_iq(struct octeon_instr_queue *iq,
>  	u32 inst_count = 0;
>  	unsigned int pkts_compl = 0, bytes_compl = 0;
>  	struct octeon_soft_command *sc;
> -	struct octeon_instr_irh *irh;
>  	unsigned long flags;
>  
>  	while (old != iq->octeon_read_index) {
> @@ -402,14 +401,6 @@ static inline void __copy_cmd_into_iq(struct octeon_instr_queue *iq,
>  		case REQTYPE_RESP_NET:
>  		case REQTYPE_SOFT_COMMAND:
>  			sc = buf;
> -
> -			if (OCTEON_CN23XX_PF(oct) || OCTEON_CN23XX_VF(oct))
> -				irh = (struct octeon_instr_irh *)
> -					&sc->cmd.cmd3.irh;
> -			else
> -				irh = (struct octeon_instr_irh *)
> -					&sc->cmd.cmd2.irh;
> -
>  			/* We're expecting a response from Octeon.
>  			 * It's up to lio_process_ordered_list() to
>  			 * process  sc. Add sc to the ordered soft
> 
> 
> .
>