netdev - Re: [PATCH] neighbour: confirm neigh entries when ARP packet is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180901.165129.1631978540527112789.davem@davemloft.net>
Date:   Sat, 01 Sep 2018 16:51:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vasilykh@...sta.com
Cc:     ihrachys@...hat.com, roopa@...ulusnetworks.com,
        adobriyan@...il.com, jwestfall@...realistic.net,
        stephen@...workplumber.org, anarsoul@...il.com,
        keescook@...omium.org, w.bumiller@...xmox.com, edumazet@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] neighbour: confirm neigh entries when ARP packet is
 received

From: Vasily Khoruzhick <vasilykh@...sta.com>
Date: Tue, 28 Aug 2018 19:48:25 -0700

> Update 'confirmed' timestamp when ARP packet is received. It shouldn't
> affect locktime logic and anyway entry can be confirmed by any higher-layer
> protocol. Thus it makes no sense not to confirm it when ARP packet is
> received.
> 
> Fixes: 77d7123342 ("neighbour: update neigh timestamps iff update is
> effective")
> 
> Signed-off-by: Vasily Khoruzhick <vasilykh@...sta.com>

I'm not so sure.

The comment above the code you are moving explains that the current
behavior is intention, and it explains why too.

Even if your change is correct, you're now making that comment
inaccuratte, so you'd have to update it to match the new code.

But I still think the current code is intentionally behaving that
way, and for good reason.