netdev - Re: [PATCH net] nfp: wait for posted reconfigs when disabling the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180831.230331.14742184049369665.davem@davemloft.net>
Date:   Fri, 31 Aug 2018 23:03:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH net] nfp: wait for posted reconfigs when disabling the
 device

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed, 29 Aug 2018 12:46:08 -0700

> To avoid leaking a running timer we need to wait for the
> posted reconfigs after netdev is unregistered.  In common
> case the process of deinitializing the device will perform
> synchronous reconfigs which wait for posted requests, but
> especially with VXLAN ports being actively added and removed
> there can be a race condition leaving a timer running after
> adapter structure is freed leading to a crash.
> 
> Add an explicit flush after deregistering and for a good
> measure a warning to check if timer is running just before
> structures are freed.
> 
> Fixes: 3d780b926a12 ("nfp: add async reconfiguration mechanism")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>

Applied and queued up for -stable.