netdev - Re: [PATCH net] bpf: Fix bpf_msg_pull

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0992bf94-1d7e-b8f8-8a6a-714ffd4444e0@iogearbox.net>
Date:   Sun, 2 Sep 2018 22:39:02 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Tushar Dave <tushar.n.dave@...cle.com>, john.fastabend@...il.com,
        ast@...nel.org, davem@...emloft.net, netdev@...r.kernel.org
Cc:     sowmini.varadhan@...cle.com
Subject: Re: [PATCH net] bpf: Fix bpf_msg_pull_data()

On 08/31/2018 11:45 PM, Tushar Dave wrote:
> Helper bpf_msg_pull_data() mistakenly reuses variable 'offset' while
> linearizing multiple scatterlist elements. Variable 'offset' is used
> to find first starting scatterlist element
>     i.e. msg->data = sg_virt(&sg[first_sg]) + start - offset"
> 
> Use different variable name while linearizing multiple scatterlist
> elements so that value contained in variable 'offset' won't get
> overwritten.
> 
> Fixes: 015632bb30da ("bpf: sk_msg program helper bpf_sk_msg_pull_data")
> Signed-off-by: Tushar Dave <tushar.n.dave@...cle.com>

Applied to bpf, thanks Tushar!