lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20180902.140440.1729935905351650374.davem@davemloft.net> Date: Sun, 02 Sep 2018 14:04:40 -0700 (PDT) From: David Miller <davem@...emloft.net> To: dsahern@...nel.org Cc: netdev@...r.kernel.org, medhefgo@....de, dsahern@...il.com Subject: Re: [PATCH net] net/ipv6: Only update MTU metric if it set From: dsahern@...nel.org Date: Thu, 30 Aug 2018 14:15:43 -0700 > From: David Ahern <dsahern@...il.com> > > Jan reported a regression after an update to 4.18.5. In this case ipv6 > default route is setup by systemd-networkd based on data from an RA. The > RA contains an MTU of 1492 which is used when the route is first inserted > but then systemd-networkd pushes down updates to the default route > without the mtu set. > > Prior to the change to fib6_info, metrics such as MTU were held in the > dst_entry and rt6i_pmtu in rt6_info contained an update to the mtu if > any. ip6_mtu would look at rt6i_pmtu first and use it if set. If not, > the value from the metrics is used if it is set and finally falling > back to the idev value. > > After the fib6_info change metrics are contained in the fib6_info struct > and there is no equivalent to rt6i_pmtu. To maintain consistency with > the old behavior the new code should only reset the MTU in the metrics > if the route update has it set. > > Fixes: d4ead6b34b67 ("net/ipv6: move metrics from dst to rt6_info") > Reported-by: Jan Janssen <medhefgo@....de> > Signed-off-by: David Ahern <dsahern@...il.com> Applied and queued up for -stable, thanks David.
Powered by blists - more mailing lists