netdev - Re: [PATCH] net: cadence: Fix a sleep-in-atomic-context bug in macb_halt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180902.160538.1996490624543458172.davem@davemloft.net>
Date:   Sun, 02 Sep 2018 16:05:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baijiaju1990@...il.com
Cc:     nicolas.ferre@...rochip.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: cadence: Fix a sleep-in-atomic-context bug in
 macb_halt_tx()

From: Jia-Ju Bai <baijiaju1990@...il.com>
Date: Sat,  1 Sep 2018 20:11:05 +0800

> The kernel module may sleep with holding a spinlock.
> 
> The function call paths (from bottom to top) in Linux-4.16 are:
> 
> [FUNC] usleep_range
> drivers/net/ethernet/cadence/macb_main.c, 648: 
> 	usleep_range in macb_halt_tx
> drivers/net/ethernet/cadence/macb_main.c, 730: 
> 	macb_halt_tx in macb_tx_error_task
> drivers/net/ethernet/cadence/macb_main.c, 721: 
> 	_raw_spin_lock_irqsave in macb_tx_error_task
> 
> To fix this bug, usleep_range() is replaced with udelay().
> 
> This bug is found by my static analysis tool DSAC.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Applied, thanks.