netdev - Re: [PATCH net-next 02/12] net: phy: et1011c: Remove incorrect missing 1000 Half

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cec12e14-1239-6dfb-177a-d653a166fb0e@gmail.com>
Date:   Mon, 3 Sep 2018 10:46:35 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>, maxime.chevallier@...tlin.com
Subject: Re: [PATCH net-next 02/12] net: phy: et1011c: Remove incorrect
 missing 1000 Half



On 9/2/2018 10:06 AM, Andrew Lunn wrote:
> The driver indicates it can do 10/100 full and half duplex, plus 1G
> Full. The datasheet indicates 1G half is also supported. So make use
> of the standard PHY_GBIT_FEATURES.
> 
> It could be, this was added because there is a MAC which does not
> support 1G half. Bit this is the wrong place to enforce this.

Indeed, this should not be left to the PHY to decide, although in my 
experience using 1000/Half is always a "roll the dice" thing, since it 
is not AFAIR properly specified.

> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian