netdev - Re: [PATCH net-next 01/12] net: phy: ste10Xp: Remove wrong SUPPORTED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Sep 2018 10:53:58 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>, maxime.chevallier@...tlin.com
Subject: Re: [PATCH net-next 01/12] net: phy: ste10Xp: Remove wrong
 SUPPORTED_Pause



On 9/2/2018 10:06 AM, Andrew Lunn wrote:
> The PHY driver should not indicate that Pause is supported. It is upto
> the MAC drive enable it, if it supports Pause frames. So remove it
> from the ste10Xp driver.

This came up before when Timur was cleaning up the Pause|ASym_Pause 
advertisment bits, and we agreed that a driver that cannot have the 
Asym_Pause bit writable, e.g: bcm63xx, would have to specifically leave 
SUPPORTED_Pause as a way to tell PHYLIB about that situation. See:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/phy?id=529ed12752635ba8a35dc78ec70ed6f42570b4ca

Can you check the datasheet if available?


> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---
>   drivers/net/phy/ste10Xp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/phy/ste10Xp.c b/drivers/net/phy/ste10Xp.c
> index fbd548a1ad84..2fe9a87b55b5 100644
> --- a/drivers/net/phy/ste10Xp.c
> +++ b/drivers/net/phy/ste10Xp.c
> @@ -86,7 +86,7 @@ static struct phy_driver ste10xp_pdriver[] = {
>   	.phy_id = STE101P_PHY_ID,
>   	.phy_id_mask = 0xfffffff0,
>   	.name = "STe101p",
> -	.features = PHY_BASIC_FEATURES | SUPPORTED_Pause,
> +	.features = PHY_BASIC_FEATURES,
>   	.flags = PHY_HAS_INTERRUPT,
>   	.config_init = ste10Xp_config_init,
>   	.ack_interrupt = ste10Xp_ack_interrupt,
> @@ -97,7 +97,7 @@ static struct phy_driver ste10xp_pdriver[] = {
>   	.phy_id = STE100P_PHY_ID,
>   	.phy_id_mask = 0xffffffff,
>   	.name = "STe100p",
> -	.features = PHY_BASIC_FEATURES | SUPPORTED_Pause,
> +	.features = PHY_BASIC_FEATURES,
>   	.flags = PHY_HAS_INTERRUPT,
>   	.config_init = ste10Xp_config_init,
>   	.ack_interrupt = ste10Xp_ack_interrupt,
> 

-- 
Florian