| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Sep 2018 15:34:53 +0100
From: Jose Abreu <Jose.Abreu@...opsys.com>
To: Jerome Brunet <jbrunet@...libre.com>,
Jose Abreu <Jose.Abreu@...opsys.com>, <netdev@...r.kernel.org>
CC: Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
"David S. Miller" <davem@...emloft.net>,
Joao Pinto <Joao.Pinto@...opsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...com>
Subject: Re: [PATCH net-next 1/2] net: stmmac: Rework coalesce timer and fix
multi-queue races
Hi Jerome,
On 04-09-2018 13:27, Jerome Brunet wrote:
> On Tue, 2018-09-04 at 10:57 +0100, Jose Abreu wrote:
>> Hi Jerome,
>>
>> On 03-09-2018 17:22, Jerome Brunet wrote:
>>> Situation is even worse with this.
>>> I'm using an NFS root filesystem. With your fixup, I'm not reaching the prompt
>>> anymore. Looks like a the same kind of network breakdown we had previously
>>>
>> I was able to reproduce your problem and the attached fixup patch
>> fixed it up for me. Can you please try?
> I suppose this applies on top the initial patch, not the previous fixup
> (judging from the rejection) Could you details the baseline for each
> patch you send, its not easy to follow.
>
> BTW, there something weird (at least for me) with the patch you attach.
> git always refuse to apply them and even patch complains:
>
> git apply fixup2.patch
> error: patch failed: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1861
> error: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: patch does not apply
>
> patch -p1 < fixup2.patch
> (Stripping trailing CRs from patch; use --binary to disable.)
> patching file drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> Hunk #6 succeeded at 2252 (offset 1 line).
> patch unexpectedly ends in middle of line
> patch unexpectedly ends in middle of line
I just do "git diff <file> > out.patch". Maybe not the best thing
to do then.
>
> Anyway, with this second fixup, I'm back to square one:
> I can boot but iperf3 won't hold for long
>
>
> # iperf3 -c 10.1.2.124 -p 12345 -t 600
> Connecting to host 10.1.2.124, port 12345
> [ 4] local 10.1.4.59 port 38650 connected to 10.1.2.124 port 12345
> [ ID] Interval Transfer Bandwidth Retr Cwnd
> [ 4] 0.00-1.00 sec 80.8 MBytes 678 Mbits/sec 1 300 KBytes
> [ 4] 1.00-2.00 sec 81.1 MBytes 680 Mbits/sec 0 329 KBytes
> [ 4] 2.00-3.00 sec 80.7 MBytes 677 Mbits/sec 0 335 KBytes
> [ 4] 3.00-4.00 sec 81.7 MBytes 685 Mbits/sec 0 337 KBytes
> [ 4] 4.00-5.00 sec 81.0 MBytes 680 Mbits/sec 0 341 KBytes
> [ 4] 5.00-6.00 sec 81.0 MBytes 680 Mbits/sec 0 344 KBytes
> [ 4] 6.00-7.00 sec 80.7 MBytes 677 Mbits/sec 0 345 KBytes
> [ 4] 7.00-8.00 sec 81.5 MBytes 684 Mbits/sec 0 346 KBytes
> [ 4] 8.00-9.00 sec 81.2 MBytes 680 Mbits/sec 0 348 KBytes
> [ 4] 9.00-10.00 sec 5.59 MBytes 46.9 Mbits/sec 2 1.41 KBytes
> [ 4] 10.00-11.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes
> [ 4] 11.00-12.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes
> [ 4] 12.00-13.00 sec 0.00 Bytes 0.00 bits/sec 1 1.41 KBytes
> [ 4] 13.00-14.00 sec 0.00 Bytes 0.00 bits/sec 0 1.41 KBytes
Okay, so this is odd because I now have a similar setup as yours
and is working perfectly fine:
---
# dmesg | grep -i stmmac
stmmaceth f0008000.ethernet: PTP uses main clock
stmmaceth f0008000.ethernet: User ID: 0x10, Synopsys ID: 0x37
stmmaceth f0008000.ethernet: DWMAC1000
stmmaceth f0008000.ethernet: DMA HW capability register supported
stmmaceth f0008000.ethernet: RX Checksum Offload Engine supported
stmmaceth f0008000.ethernet: COE Type 2
stmmaceth f0008000.ethernet: TX Checksum insertion supported
stmmaceth f0008000.ethernet: Normal descriptors
stmmaceth f0008000.ethernet: Ring mode enabled
stmmaceth f0008000.ethernet: Enable RX Mitigation via HW Watchdog
Timer
libphy: stmmac: probed
stmmaceth f0008000.ethernet eth0: device MAC address
0e:67:f6:6c:59:c6
Micrel KSZ9031 Gigabit PHY stmmac-0:00: attached PHY driver
[Micrel KSZ9031 Gigabit PHY] (mii_bus:phy_addr=stmmac-0:00, irq=POLL)
stmmaceth f0008000.ethernet eth0: No Safety Features support found
stmmaceth f0008000.ethernet eth0: PTP not supported by HW
stmmaceth f0008000.ethernet eth0: Link is Up - 1Gbps/Full - flow
control off
stmmaceth f0008000.ethernet eth0: Link is Down
stmmaceth f0008000.ethernet eth0: Link is Up - 1Gbps/Full - flow
control off
---
# iperf3 -c 192.168.0.3 -t 600
Connecting to host 192.168.0.3, port 5201
[ 4] local 192.168.0.1 port 46796 connected to 192.168.0.3 port 5201
[ ID] Interval Transfer Bandwidth Retr Cwnd
[ 4] 0.00-1.01 sec 101 MBytes 841 Mbits/sec 1 467
KBytes
[ 4] 1.01-2.00 sec 112 MBytes 945 Mbits/sec 0 475
KBytes
[ 4] 2.00-3.01 sec 114 MBytes 947 Mbits/sec 0 481
KBytes
[ 4] 3.01-4.00 sec 112 MBytes 945 Mbits/sec 0 486
KBytes
[ 4] 4.00-5.00 sec 113 MBytes 947 Mbits/sec 0 506
KBytes
[ 4] 5.00-6.01 sec 113 MBytes 947 Mbits/sec 0 520
KBytes
[ 4] 6.01-7.00 sec 112 MBytes 950 Mbits/sec 0 625
KBytes
[ 4] 7.00-8.01 sec 114 MBytes 948 Mbits/sec 0 625
KBytes
[ 4] 8.01-9.00 sec 112 MBytes 948 Mbits/sec 0 625
KBytes
[ 4] 9.00-10.00 sec 114 MBytes 955 Mbits/sec 0 998
KBytes
[ 4] 10.00-11.01 sec 114 MBytes 949 Mbits/sec 0 998
KBytes
[ 4] 11.01-12.00 sec 113 MBytes 949 Mbits/sec 0 998
KBytes
[ 4] 12.00-13.00 sec 114 MBytes 954 Mbits/sec 0 998
KBytes
[ 4] 13.00-14.00 sec 114 MBytes 950 Mbits/sec 0 998
KBytes
[ 4] 14.00-15.01 sec 114 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 15.01-16.00 sec 113 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 16.00-17.00 sec 114 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 17.00-18.01 sec 114 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 18.01-19.00 sec 113 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 19.00-20.00 sec 114 MBytes 951 Mbits/sec 0 998
KBytes
[ 4] 20.00-21.00 sec 112 MBytes 947 Mbits/sec 0 998
KBytes
[ And just keeps going on ]
---
Note that although the User ID is not the same (0x10 vs 0x11) the
callbacks and the sw flow is the same, there are no differences
regarding User ID in stmmac driver, only the Synopsys ID is used.
Maybe some feature is not enabled in your HW ?
Thanks and Best Regards,
Jose Miguel Abreu
>
>
>> Thanks and Best Regards,
>> Jose Miguel Abreu
>
Powered by blists - more mailing lists