netdev - Re: [PATCH net-next] net: sched: null actions array pointer before releasing action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180903.214754.1769188450969981251.davem@davemloft.net>
Date:   Mon, 03 Sep 2018 21:47:54 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     vladbu@...lanox.com, netdev@...r.kernel.org, jhs@...atatu.com,
        jiri@...nulli.us
Subject: Re: [PATCH net-next] net: sched: null actions array pointer before
 releasing action

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Mon, 3 Sep 2018 11:18:43 -0700

> On Mon, Sep 3, 2018 at 12:05 AM Vlad Buslov <vladbu@...lanox.com> wrote:
>>
>> Currently, tcf_action_delete() nulls actions array pointer after putting
>> and deleting it. However, if tcf_idr_delete_index() returns an error,
>> pointer to action is not set to null. That results it being released second
>> time in error handling code of tca_action_gd().
> 
> Oops, good catch.
> 
> Acked-by: Cong Wang <xiyou.wangcong@...il.com>
> 
> David, this one should also go to -net rather than -net-next.

Applied to 'net', thanks.