netdev - Re: [PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <390fdef0-4a37-4f88-881a-941373aff563@default>
Date:   Tue, 4 Sep 2018 00:36:04 -0700 (PDT)
From:   Liran Alon <liran.alon@...cle.com>
To:     <yuehaibing@...wei.com>
Cc:     <sridhar.samudrala@...el.com>, <alexander.h.duyck@...el.com>,
        <stephen@...workplumber.org>, <jeffrey.t.kirsher@...el.com>,
        <netdev@...r.kernel.org>, <dan.carpenter@...cle.com>,
        <davem@...emloft.net>, <kernel-janitors@...r.kernel.org>,
        <joao.m.martins@...cle.com>
Subject: Re: [PATCH v2 net-next] failover: Add missing check to validate
 'slave_dev' in net_failover_slave_unregister


----- yuehaibing@...wei.com wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/net_failover.c: In function
> 'net_failover_slave_unregister':
> drivers/net/net_failover.c:598:35: warning:
>  variable 'primary_dev' set but not used [-Wunused-but-set-variable]
> 
> There should check the validity of 'slave_dev'.
> 
> Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
> v2: use WARN_ON_ONCE as Liran Alon suggested
> ---
>  drivers/net/net_failover.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
> index 7ae1856..5a749dc 100644
> --- a/drivers/net/net_failover.c
> +++ b/drivers/net/net_failover.c
> @@ -603,6 +603,9 @@ static int net_failover_slave_unregister(struct
> net_device *slave_dev,
>  	primary_dev = rtnl_dereference(nfo_info->primary_dev);
>  	standby_dev = rtnl_dereference(nfo_info->standby_dev);
>  
> +	if (WARN_ON_ONCE(slave_dev != primary_dev && slave_dev !=
> standby_dev))
> +		return -ENODEV;
> +

I prefer to put () around different conditions but that's just a matter of taste.
Reviewed-by: Liran Alon <liran.alon@...cle.com>

>  	vlan_vids_del_by_dev(slave_dev, failover_dev);
>  	dev_uc_unsync(slave_dev, failover_dev);
>  	dev_mc_unsync(slave_dev, failover_dev);