netdev - Re: [Patch net] tipc: fix a missing rhashtable_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2eb93e79-eb06-0e7a-b57a-c8021b0c2cd3@windriver.com>
Date:   Tue, 4 Sep 2018 17:13:39 +0800
From:   Ying Xue <ying.xue@...driver.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, <netdev@...r.kernel.org>
CC:     Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [Patch net] tipc: fix a missing rhashtable_walk_exit()

On 08/24/2018 07:19 AM, Cong Wang wrote:
> rhashtable_walk_exit() must be paired with rhashtable_walk_enter().
> 
> Fixes: 40f9f4397060 ("tipc: Fix tipc_sk_reinit race conditions")
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Acked-by: Ying Xue <ying.xue@...driver.com>

> ---
>  net/tipc/socket.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index c1e93c9515bc..c9a50b62c738 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -2672,6 +2672,8 @@ void tipc_sk_reinit(struct net *net)
>  
>  		rhashtable_walk_stop(&iter);
>  	} while (tsk == ERR_PTR(-EAGAIN));
> +
> +	rhashtable_walk_exit(&iter);
>  }
>  
>  static struct tipc_sock *tipc_sk_lookup(struct net *net, u32 portid)
>