netdev - Re: [PATCH 01/25] tty: Change return type to void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d3d5df26-4678-2539-e579-1c48bc726163@suse.cz>
Date:   Wed, 5 Sep 2018 07:57:25 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     Jaejoong Kim <climbbb.kim@...il.com>,
        sergei.shtylyov@...entembedded.com
Cc:     devel@...verdev.osuosl.org, Greg KH <gregkh@...uxfoundation.org>,
        linux-um@...ts.infradead.org, greybus-dev@...ts.linaro.org,
        linuxppc-dev@...ts.ozlabs.org, linux-bluetooth@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, linux-mmc@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-serial@...r.kernel.org,
        USB list <linux-usb@...r.kernel.org>, netdev@...r.kernel.org,
        sparclinux@...r.kernel.org
Subject: Re: [PATCH 01/25] tty: Change return type to void

On 09/05/2018, 03:08 AM, Jaejoong Kim wrote:
>     > @@ -688,7 +688,7 @@ extern int tty_port_close_start(struct
>     tty_port *port,
>     >   extern void tty_port_close_end(struct tty_port *port, struct
>     tty_struct *tty);
>     >   extern void tty_port_close(struct tty_port *port,
>     >                               struct tty_struct *tty, struct file
>     *filp);
>     > -extern int tty_port_install(struct tty_port *port, struct
>     tty_driver *driver,
>     > +extern void tty_port_install(struct tty_port *port, struct
>     tty_driver *driver,
>     >                               struct tty_struct *tty);
> 
>         You need to update all the callers in the same patch -- the
>     kernel must
>     remain buildable after each patch but you seem to have spread that
>     update
>     among a lot of patches..
> 
> 
> OK. I will make several patches as one patch.

You don't have to. Just reorder the patches as suggested by Sam. (First,
make everybody ignore the return value, then change these return types
to void.)

BTW you can mention in this commit log, that this change is possible
after a3123fd0a4a5. That commit made tty_standard_install to always
return 0.

thanks,
-- 
js
suse labs