netdev - Re: [PATCH] ath9k: add reset for airtime station debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sh2mykmt.fsf@toke.dk>
Date:   Thu, 06 Sep 2018 12:40:10 +0200
From:   Toke Høiland-Jørgensen <toke@...e.dk>
To:     Louie Lu <git@...ie.lu>
Cc:     kvalo@...eaurora.org, ath9k-devel@....qualcomm.com,
        davem@...emloft.net, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] ath9k: add reset for airtime station debugfs

Louie Lu <git@...ie.lu> writes:

> Toke Høiland-Jørgensen <toke@...e.dk> 於 2018年9月6日 週四 下午5:27寫道：
>
>> Louie Lu <git@...ie.lu> writes:
>>
>> > Let user can reset station airtime status by debugfs, it will
>> > reset all airtime deficit to ATH_AIRTIME_QUANTUM and reset rx/tx
>> > airtime accumulate to 0.
>>
>> No objections to the patch, but I'm curious which issues you were
>> debugging that led you to needing it? :)
>>
> I'm testing to get the packet queue time + airtime in
> ath_tx_process_buffer,

Right; I've been thinking that it would be useful to make the CoDel
enqueue time available to drivers. And minstrel, for that matter
(lowering the number of retries for packets that has queued for a long
time, for instance). Good to hear that others are looking into something
similar :)

> it would be useful if I can reset the station airtime accumulated
> value, so I can observe in each test round (e.g. 5 ping) airtime
> accumulated
>
> Also to reset the deficit to make sure it run like fresh one.

Yup, makes sense.

-Toke