netdev - Re: [PATCH net-next v1] net/tls: Set count of SG entries if sk_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180906112253.GA29860@bistromath.localdomain>
Date:   Thu, 6 Sep 2018 13:22:53 +0200
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Vakul Garg <vakul.garg@....com>
Cc:     netdev@...r.kernel.org, borisp@...lanox.com, aviadye@...lanox.com,
        davejwatson@...com, davem@...emloft.net, doronrk@...com
Subject: Re: [PATCH net-next v1] net/tls: Set count of SG entries if
 sk_alloc_sg returns -ENOSPC

2018-09-05, 21:57:43 +0530, Vakul Garg wrote:
> tls_sw_sendmsg() allocates plaintext and encrypted SG entries using
> function sk_alloc_sg(). In case the number of SG entries hit
> MAX_SKB_FRAGS, sk_alloc_sg() returns -ENOSPC and sets the variable for
> current SG index to '0'. This leads to calling of function
> tls_push_record() with 'sg_encrypted_num_elem = 0' and later causes
> kernel crash. To fix this, set the number of SG elements to the number
> of elements in plaintext/encrypted SG arrays in case sk_alloc_sg()
> returns -ENOSPC.
> 
> Signed-off-by: Vakul Garg <vakul.garg@....com>

What commit introduced this bug? Can you add Fixes: tag? And if it's a
bug present in the net tree, the fix should go into the net tree as
well.


Another thing I've noticed a few times with your patch submissions:
the clock on the system you're using for git-send-email seems to be
set something like 5 hours and 18 minutes in the future. Could you fix
it?  It makes your email appear out of order.

Date: Wed,  5 Sep 2018 21:57:43 +0530

Received: from lti.ap.freescale.net (14.143.30.134) by
        AM0PR04MB4243.eurprd04.prod.outlook.com (2603:10a6:208:66::29) with Microsoft
        SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
        15.20.1101.17; Wed, 5 Sep 2018 11:09:20 +0000

-- 
Sabrina