netdev - Re: [iproute PATCH] ip-route: Fix segfault with many nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180906125404.GF20453@orbyte.nwl.cc>
Date:   Thu, 6 Sep 2018 14:54:05 +0200
From:   Phil Sutter <phil@....cc>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute PATCH] ip-route: Fix segfault with many nexthops

Hi,

On Tue, Sep 04, 2018 at 07:15:44PM +0200, Phil Sutter wrote:
[...]
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 30833414a3f7f..9e5ae48c0715c 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
[...]
> @@ -1036,15 +1044,18 @@ static int parse_nexthops(struct nlmsghdr *n, struct rtmsg *r,
>  		memset(rtnh, 0, sizeof(*rtnh));
>  		rtnh->rtnh_len = sizeof(*rtnh);
>  		rta->rta_len += rtnh->rtnh_len;
> -		if (parse_one_nh(n, r, rta, rtnh, &argc, &argv)) {
> +		if (parse_one_nh(n, r, rta, 1024, rtnh, &argc, &argv)) {
>  			fprintf(stderr, "Error: cannot parse nexthop\n");
>  			exit(-1);
>  		}
>  		rtnh = RTNH_NEXT(rtnh);
>  	}
>  
> +		return 0;
> +

This line got added by accident, I'll respin.

Sorry, Phil